[Fuego] [PATCH] busybox: modify the code of option g+x in chmod1 test

[Wang, Mingyu]

Hi Tim,

I didn't find out where the problem was. Maybe because my mail client is in Chinese.
I have changed it to the English version and revised the patch and sent it again.

by Wangmy

-----Original Message-----
From: Tim.Bird at sony.com [mailto:Tim.Bird at sony.com] 
Sent: Tuesday, July 24, 2018 7:25 AM
To: Wang, Mingyu/王 鸣瑜 <wangmy at cn.fujitsu.com>; fuego at lists.linuxfoundation.org
Subject: RE: [Fuego] [PATCH] busybox: modify the code of option g+x in chmod1 test

OK - this is applied and pushed.  But it was a bit harder to apply than anticipated because your mailer decided to put the message body in base64 encoding.

You other patches don't have this issue.  I'm not sure what happened on this one.  The only thing I can think of is maybe there was a non-8-bit-ASCII character somewhere in the patch?  The only "strange" characters are the quotes (maybe in the patch message) - maybe one of those got turned into a Unicode char or some other extended character-set character.

If you can, please check this.
 -- Tim


> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego- 
> bounces at lists.linuxfoundation.org] On Behalf Of Wang Mingyu
> Sent: Sunday, July 22, 2018 10:35 PM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH] busybox: modify the code of option g+x in 
> chmod1 test
> 
> Change the cut to retrieve the group permission bytes, to check that 
> they are 'execute' ('x').
> 
> Signed-off-by: Wang Mingyu <wangmy at cn.fujitsu.com>
> ---
>  engine/tests/Functional.busybox/tests/busybox_chmod1.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/engine/tests/Functional.busybox/tests/busybox_chmod1.sh
> b/engine/tests/Functional.busybox/tests/busybox_chmod1.sh
> index cdc7d18..2eef95a 100644
> --- a/engine/tests/Functional.busybox/tests/busybox_chmod1.sh
> +++ b/engine/tests/Functional.busybox/tests/busybox_chmod1.sh
> @@ -21,7 +21,7 @@ else
>  fi;
> 
>  busybox chmod g+x ./test_dir/test1
> -if [ "$(busybox ls -l ./test_dir | grep -v "total" | cut -b 1-3)" = 
> "-rw" ]
> +if [ "$(busybox ls -l ./test_dir | grep -v "total" | cut -b 5-7)" = 
> +"r-x" ]
>  then
>      echo " -> $test: Changed file permissions verification#2 succeeded."
>  else
> --
> 1.8.3.1
> 
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego