[Fuego] [PATCH 27/30] functions: logdir not required here
Tim.Bird at sony.com
Tim.Bird at sony.com
Wed Jun 6 23:09:15 UTC 2018
> -----Original Message-----
> From: Daniel Sangorrin
>
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
> engine/scripts/functions.sh | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/engine/scripts/functions.sh b/engine/scripts/functions.sh
> index 654a1ee..68e31e7 100755
> --- a/engine/scripts/functions.sh
> +++ b/engine/scripts/functions.sh
> @@ -453,8 +453,6 @@ function pre_test {
> # Target cleanup flag check
> [ "$Target_PreCleanup" = "true" ] && target_cleanup $TESTDIR || true
>
> - export
> LOGDIR="$FUEGO_RW/logs/$TESTDIR/${NODE_NAME}.${TESTSPEC}.${BUIL
> D_NUMBER}.${BUILD_ID}"
> -
> # see if test dependencies (expressed by NEED_ vars) are met
> check_needs || abort_job "Test dependencies (expressed by NEED
> variables) not met"
>
> --
> 2.7.4
NAK on this one. I still have plenty of jobs that call main.sh, without going
through ftc first. To be backwards-compatible with those, I'd like to leave
this definition here. I know it's redundant with the definition made by
ftc.
Maybe we should have a FIXTHIS here, reminding us to remove this when
we're willing to pull the plug on running pre-1.4 Fuego jobs.
-- Tim
More information about the Fuego
mailing list