[Fuego] Multiple problems with busybox tests

Wang, Mingyu wangmy at cn.fujitsu.com
Tue Jun 12 03:14:31 UTC 2018


Hi Tim:

>I fixed many of them.  See commit  2f0661ce0 in my master branch.
>Please look at the issues I resolved, and try to avoid them in future
>patches:
>- ls issues 'total' line
> - some echos don't support -e
>http://wiki.bash-hackers.org/syntax/pe#substring_removal
>Can you please look at these and propose fixes.
Thank you very much for making these suggestions, which is very helpful for me as a beginner.
I will also pay attention to these issues in future patch.

>A few tests are still not working for me. 
> - busybox_chvt.sh - tty returns either 'not a tty' or '/dev/pts/0'.
>   - neither of these values is handled correctly by the script.
As for the chvt command, because the test is performed by ssh remote login to board, the result of the execution of the command tty should be /dev/pts/0, so that the current test set is meaningless.
Can it be tested like following:
chvt 1 
echo $? = 0

chvt 1000
echo $?=1

Because tty1 should exist, but tty1000 does not exist theoretically.

> - busybox_chroot.sh - line 17 'j=${i:1:5}' is a bashims not support on several of my boards
>    - please find another way to extract the library path
Whether it can be changed to the following:
j=$(expr substr "$i" 2 5)

by Wangmy.

-----Original Message-----
From: Tim.Bird at sony.com [mailto:Tim.Bird at sony.com] 
Sent: Tuesday, June 12, 2018 8:37 AM
To: Wang, Mingyu/王 鸣瑜 <wangmy at cn.fujitsu.com>; fuego at lists.linuxfoundation.org
Subject: Multiple problems with busybox tests

Wang,

When I got into testing the busybox tests on my boards, I saw numerous problems.

I fixed many of them.  See commit  2f0661ce0 in my master branch.
Please look at the issues I resolved, and try to avoid them in future
patches:
 - ls issues 'total' line
 - some echos don't support -e
 - 

A few tests are still not working for me. 
 - busybox_chvt.sh - tty returns either 'not a tty' or '/dev/pts/0'.
    - neither of these values is handled correctly by the script.
 - busybox_chroot.sh - line 17 'j=${i:1:5}' is a bashims not support on several of my boards
    - please find another way to extract the library path

Note that posix shells do support variable substring removal.  So this might work See http://wiki.bash-hackers.org/syntax/pe#substring_removal

Can you please look at these and propose fixes.

All your patches were applied and pushed in my master branch.
 -- Tim







More information about the Fuego mailing list