[Fuego] [PATCH 26/30] bang: replace the jenkins script
Tim.Bird at sony.com
Tim.Bird at sony.com
Thu Jun 14 05:52:19 UTC 2018
> -----Original Message-----
> From: Daniel Sangorrin
> > -----Original Message-----
> > From: Tim.Bird at sony.com [mailto:Tim.Bird at sony.com]
> > That will be fine. I ran into problems with the patches, that I would like
> > to resolve in a 'next' branch before I commit it to master. I'm working
> > to rebase your previous patches and push them to my own 'next' branch,
> > and get your fixes (and additional fixes I'm making) on that branch,
> > before pulling it back to the master branch.
> > Let me know if this workflow will work for you.
OK - my 'next' branch has the patches. Can you test it out, or do continued
integration (for these features) on that branch?
One issue I saw with the switchover to Jenkins calling 'ftc run-test', was that
abort messages don't show up in the Jenkins console log. There must
be some pipe flushing problem between ftc and Jenkins. I'm not sure if this
shows up on the ftc command line (run outside of Jenkins).
A secondary issue I'd like to get working again (it may have broken sometime
in the 1.3 release), is to support running a test when there is no matching
jenkins job. Some of the code I saw made it look like this support was removed,
but I could have misinterpreted. (e.g. find_next_build_number_by_log_scan).
Also, the code for adding a build.xml file to Jenkins for a run that was run outside
of Jenkins control, is commented out (as you noted in your patch). The reason
for this is that the format of the build.xml file changed when we upgraded Jenkins
versions, and I didn't have time to go back and support the new format. One
big change in the build.xml format is how the trigger is expressed. It's now
much more convoluted.
Sorry I'm busy with other things this week, but I may have time to take a look
at some things tomorrow.
In general, I don't see backwards compatibility issues with the dynamic variables
stuff, or support for ftc command line options for reboot, precleanup, etc.
So, if those patches are separate from the 'call ftc run-test from jenkins' feature,
these could be pulled over to the master branch independently (and sooner).
More information about the Fuego