[Fuego] [PATCH 28/30] logdir: a few changes

Tim.Bird at sony.com Tim.Bird at sony.com
Thu Jun 14 05:52:56 UTC 2018



> -----Original Message-----
> From: Daniel Sangorrin 
> > -----Original Message-----
> > From: Tim.Bird at sony.com [mailto:Tim.Bird at sony.com]
> > > > This change also makes the code backwards-incompatible with
> previously-
> > > defined
> > > > jobs.  To support backwards-compatibility, can we check for spec.json
> > > > in logdir, and if not present fall back to reading spec.json from the test
> > > directory?
> > >
> > > Do you mean that in a previous version a spec.json was recorded into the
> > > logdir? I haven't seen this functionality.
> >
> > No. I mean something like this (in ovgen.py):
> > specpath = logdir + "/spec.json"
> > if not os.path.exists(spec_path):
> >     specpath = testdir + "/spec.json"
> 
> OK, I see what you mean.
> You mean that it causes backwards-compatibility with jobs created in the
> past.
> I can fix that.
> 
> On the other hand, I think we should mark these backwards compatibility so
> that we can remove it in the future (I think it is called expand/collapse
> pattern or something like that) to keep the source maintainable.

Agreed.
 -- Tim


More information about the Fuego mailing list