[Fuego] [PATCH 01/11] ltp: convert skiplist comments to messages

Daniel Sangorrin daniel.sangorrin at toshiba.co.jp
Thu Mar 1 08:27:12 UTC 2018

Show the reasons for skipping certain test cases on the
fuego log.

Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
 engine/tests/Functional.LTP/fuego_test.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/engine/tests/Functional.LTP/fuego_test.sh b/engine/tests/Functional.LTP/fuego_test.sh
index de9ed27..ad130a8 100755
--- a/engine/tests/Functional.LTP/fuego_test.sh
+++ b/engine/tests/Functional.LTP/fuego_test.sh
@@ -203,7 +203,7 @@ function test_pre_check {
     rm -f $target_mounts
-    # Tests skipped by Linux kernel version
+    echo "Tests skipped by Linux kernel version"
     # FIXTHIS: compare with the kernel version before adding tests to the skiplist
     kver=$(cmd "uname -r")
     echo "kernel version: $kver"
@@ -213,7 +213,7 @@ function test_pre_check {
     skip_tests "inotify06" # will loop/crash kernels that dont have commit 8f2f3eb59dff (<4.2)
     skip_tests "ptrace03" # Only works for <2.6.26, above that the kernel allows to trace init
-    # Tests skipped depending on the availability of a command on the target
+    echo "Tests skipped depending on the availability of a command on the target"
     # FIXTHIS: only check the necessary ones
     skip_if_command_unavailable bash "rwtest01 rwtest02 rwtest04 rwtest05 iogen01 fs_inod01 fs_di BindMounts"
     skip_if_command_unavailable expect "su01"
@@ -234,13 +234,13 @@ function test_pre_check {
     skip_if_command_unavailable touch "ext4-nsec-timestamps"
     skip_if_command_unavailable quotacheck "quotactl01"
-    # Tests skipped depending on the configuration of the target kernel
+    echo "Tests skipped depending on the configuration of the target kernel"
     skip_if_kconfig_differs "CONFIG_INOTIFY_USER=y" "inotify_init1_01 inotify_init1_02 inotify01 inotify02 inotify03 inotify04 inotify05 inotify06"
     skip_if_kconfig_differs "CONFIG_FANOTIFY=y CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y" "fanotify01 fanotify02 fanotify03 fanotify04 fanotify05 fanotify06"
     skip_if_kconfig_differs "CONFIG_EXT4_FS=y CONFIG_EXT4DEV_COMPAT=y CONFIG_EXT4_FS_XATTR=y CONFIG_EXT4_FS_POSIX_ACL=y CONFIG_EXT4_FS_SECURITY=y" "ext4-nsec-timestamps"
     skip_if_kconfig_differs "CONFIG_CHECKPOINT_RESTORE=y" "kcmp01 kcmp02 kcmp03"
-    # Tests skipped depending on the architecture
+    echo "Tests skipped depending on the architecture"
     if [ "$ARCHITECTURE" = "x86_64" ]; then
         skip_tests "chown01_16 chown02_16 chown03_16 chown04_16 chown05_16"
         skip_tests "fchown01_16 fchown02_16 fchown03_16 fchown04_16 fchown05_16"
@@ -275,7 +275,7 @@ function test_build {
             --with-open-posix-testsuite --with-realtime-testsuite --without-perl --without-python --target=$PREFIX --host=$PREFIX \
             --prefix=`pwd`/target_bin --build=`uname -m`-unknown-linux-gnu
-        # Skip tests depending on the results of configure (e.g.: SDK requirements)
+        echo "Tests skipped depending on the results of LTP ./configure (e.g.: SDK requirements)"
         skip_if_config_unavailable "HAVE_XFS_QUOTA" "quotactl02" "Try adding xfslibs-dev to your SDK"
         skip_if_config_unavailable "HAVE_QUOTAV" "quotactl01 quotactl02" "Try adding libc6-dev to your SDK"
         skip_if_config_unavailable "HAVE_NUMA" "get_mempolicy01 mbind01 migrate_pages01 migrate_pages02 move_pages01 move_pages02 move_pages03 move_pages04 move_pages05 move_pages06 move_pages07 move_pages08 move_pages09 move_pages10 move_pages11" "No NUMA support"

More information about the Fuego mailing list