[Fuego] [PATCH 11/11] ltp: fix bug related to build-time skip tests

[Tim.Bird at sony.com]

> -----Original Message-----
> From: Daniel Sangorrin
> We need to update the skiplist during the deploy phase because
> the build phase is only called once by default.
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
>  engine/tests/Functional.LTP/fuego_test.sh | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/engine/tests/Functional.LTP/fuego_test.sh
> b/engine/tests/Functional.LTP/fuego_test.sh
> index c8459ee..6fa0bc7 100755
> --- a/engine/tests/Functional.LTP/fuego_test.sh
> +++ b/engine/tests/Functional.LTP/fuego_test.sh
> @@ -301,13 +301,15 @@ function test_build {
>          cp $TEST_HOME/ltp_target_run.sh target_bin
>      else
>          echo "Skipping LTP build"
> -        if [ -f "${WORKSPACE}/${JOB_BUILD_DIR}/buildskipfile.txt" ]; then
> -            cat "${WORKSPACE}/${JOB_BUILD_DIR}/buildskipfile.txt" >>
> ${LOGDIR}/skiplist.txt
> -        fi
>      fi
>  }
> 
>  function test_deploy {
> +    if [ -f "${WORKSPACE}/${JOB_BUILD_DIR}/buildskipfile.txt" ]; then
> +        echo "Appending tests skipped during the build phase to the skiplist."
> +        cat "${WORKSPACE}/${JOB_BUILD_DIR}/buildskipfile.txt" >>
> ${LOGDIR}/skiplist.txt
> +    fi
> +
I'm worried about the skiplist, when we run the 'makepkg' or 'install' specs.
Is it correct to not install these on the board, even when making (semi-)permanent
installation of LTP on a board.

For example, what if someone installs LTP, using a skiplist based on a kernel
configuration, and then changes the kernel (with a different configuration) on
the board.  There might be a mismatch between what's installed and what
Fuego tries to run.

Any ideas for avoiding this problem?  Maybe compare installed skiplist with
generated skiplist at time of test?

>      # Add tests to skip if "skiplist" is defined on the spec. The "skiplist"
>      # can contain LTP test_case names (e.g.: inotify06) and/or absolute path(s)
>      # to skipfiles (text files containing a list of LTP test case names)
> --
> 2.7.4

Above issue is a more general concern, not related to this patch.
This one is acked and pushed.
 -- Tim