[Fuego] [PATCH 06/11] tests: add new iperf3

Tim.Bird at sony.com Tim.Bird at sony.com
Wed Mar 7 19:18:54 UTC 2018

> -----Original Message-----
> From: Daniel Sangorrin [mailto:daniel.sangorrin at toshiba.co.jp]
> > > The tarball is sent on the next patch. It was downloaded
> > > from https://iperf.fr/download/source/iperf-3.1.3-source.tar.gz
> >
> > It would be good to document the source of the tarball inside
> > the fuego_test.sh (or in test.yaml, but we're not really using that yet).
> >
> > What do you think about adding the following, to fuego_test.sh:
> > tarball_src=https://iperf.fr/download/source/iperf-3.1.3-source.tar.gz
> >
> > I'm not sure about the variable name we should use for this, or I would
> > have added this myself.   The idea is
> > NOT to have Fuego automatically download the source, but rather just
> > to give maintainers (and users) a reference to the source for test
> > maintenance work.  This could also be put into a comment, to more
> > clearly indicate that it's not being processed (currently) by Fuego.
> > Let me know what you think.
> I think this kind of metadata should in fact go to the test.yaml file.
> I have sent to you a test.yaml file for iperf3 including that variable.
> I have also included another one showing the params accepted by the test.
> I would like to put the params on the spec file, but json does not accept
> comments.

Yes.  That might bite us in the long run.  But for now, human-readable
stuff can go into test.yaml.  I approved your previous patch, and like
that approach for now.

 -- Tim

More information about the Fuego mailing list