[Fuego] [PATCH 1/3] iperf3: remove parameter description from fuego_test

Tim.Bird at sony.com Tim.Bird at sony.com
Wed Mar 7 23:12:30 UTC 2018


Applied. Thanks.
 -- Tim

> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> bounces at lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Friday, March 02, 2018 12:57 AM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 1/3] iperf3: remove parameter description from
> fuego_test
> 
> The description is provided in test.yaml instead.
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
>  engine/tests/Benchmark.iperf3/fuego_test.sh | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/engine/tests/Benchmark.iperf3/fuego_test.sh
> b/engine/tests/Benchmark.iperf3/fuego_test.sh
> index 4bbfc22..e981967 100755
> --- a/engine/tests/Benchmark.iperf3/fuego_test.sh
> +++ b/engine/tests/Benchmark.iperf3/fuego_test.sh
> @@ -1,15 +1,6 @@
>  # gitrepo=https://github.com/esnet/iperf.git
>  tarball=iperf-3.1.3-source.tar.gz
> 
> -# Spec parameters
> -#  - [Optional] server_ip (BENCHMARK_IPERF3_SERVER_IP): ip address of
> the server machine
> -#        - if not provided, then SRV_IP _must_ be provided on the board file.
> Otherwise the test will fail.
> -#        - if the server ip is assigned to the host, the test automatically starts
> the iperf3 server daemon
> -#            - otherwise, the tester _must_ make sure that 'iperf3 -V -s -D' is
> already running on the server machine.
> -#              FIXTHIS: add functionality to setup the server using a board file
> -#  - [Optional] server_params (BENCHMARK_IPERF3_SERVER_PARAMS):
> extra parameters for the server
> -#  - [Optional] client_params (BENCHMARK_IPERF3_SERVER_PARAMS):
> extra parameters for the client
> -
>  function test_build {
>      ./configure --host=$HOST --prefix=$(pwd)/build
>      make
> @@ -22,7 +13,7 @@ function test_deploy {
> 
>  function test_run {
>      # FIXTHIS: validate the server and client ips, and make sure they can
> communicate
> -
> +    # FIXTHIS: add functionality to setup the server using a board file
>      # Get the server ip
>      IPERF3_SERVER_IP=${BENCHMARK_IPERF3_SERVER_IP:-$SRV_IP}
>      if [ -z "$IPERF3_SERVER_IP" ]; then
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list