[Fuego] [PATCH 2/2] yaml: add yaml for iperf3

Daniel Sangorrin daniel.sangorrin at toshiba.co.jp
Fri Mar 9 06:44:03 UTC 2018


> -----Original Message-----
> From: Tim.Bird at sony.com [mailto:Tim.Bird at sony.com]
> Sent: Thursday, March 08, 2018 4:17 AM
> To: daniel.sangorrin at toshiba.co.jp; fuego at lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH 2/2] yaml: add yaml for iperf3
> 
> Comments inline below.
> 
> > -----Original Message-----
> > From: Daniel Sangorrin
> >
> > I added a few new variables that may need discussion:
> > - tarball_src
> > - gitrepo
> > - params
> >
> > Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> > ---
> >  engine/tests/Benchmark.iperf3/test.yaml | 44
> > +++++++++++++++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >  create mode 100644 engine/tests/Benchmark.iperf3/test.yaml
> >
> > diff --git a/engine/tests/Benchmark.iperf3/test.yaml
> > b/engine/tests/Benchmark.iperf3/test.yaml
> > new file mode 100644
> > index 0000000..a11fd83
> > --- /dev/null
> > +++ b/engine/tests/Benchmark.iperf3/test.yaml
> > @@ -0,0 +1,44 @@
> > +fuego_package_version: 1
> > +name: Benchmark.iperf3
> > +description: |
> > +    iPerf3 is a tool for active measurements of the maximum achievable
> > +    bandwidth on IP networks.
> > +license: three-clause BSD license.
> 
> We will probably want to adopt official SPDX license tags for the license field.
> I know my own license fields on other files don't follow this.  But I think
> we should use something official going forward.
> 
> Can you please select the correct 3-clause license identifier from:
> https://spdx.org/licenses/
> and apply it here.  (I've applied the patch, so you should just be able
> to change this field).

I changed it, see the patch.

> > +author: |
> > +    Jon Dugan, Seth Elliott, Bruce A. Mah, Jeff Poskanzer, Kaustubh Prabhu,
> > +    Mark Ashley, Aaron Brown, Aeneas Jaißle, Susant Sahani, Bruce Simpson,
> Aeneas' last name triggered a Unicode-handling bug on the prototype
> Fuego test server. I get an error trying to display the yaml fields on
> the following page:
> http://fuegotest.org/server/Benchmark.iperf3
> 
> I got the package onto the server with:
> ftc put-test Benchmark.iperf3
> 
> This built the package according to the test.yaml file, and uploaded the
> package to the prototype server area.
> 
> The page display issue is a bug I'll have to fix.  Since the server is only
> a prototype at the moment, and is not a production part of Fuego yet,
> and we really should support non-ascii-7-bit-clean characters in these
> text fields in the yaml file, I'm going to leave this as is, and come back
> and try to fix the server code (which is in ProcessorFuegoShow.py in
> my wiki software) later.

Sorry about that. There was a warning about the encoding (UTF-8) when i did the
git send-email.

> 
> > +    Brian Tierney.
> > +maintainer: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> > +version: 0.1
> > +fuego_release: 1.2.1
> > +type: Benchmark
> > +tags: ['network', 'performance']
> > +tarball_src: https://iperf.fr/download/source/iperf-3.1.3-source.tar.gz
> > +gitrepo: https://github.com/esnet/iperf.git
> > +params:
> > +    - server_ip:
> > +        description: |
> > +            IP address of the server machine. If not provided, then SRV_IP
> > +            _must_ be provided on the board file. Otherwise the test will fail.
> > +            if the server ip is assigned to the host, the test automatically
> > +            starts the iperf3 server daemon. Otherwise, the tester _must_ make
> > +            sure that iperf3 -V -s -D is already running on the server machine.
> > +        example: 192.168.1.45
> > +        optional: yes
> > +    - server_params:
> > +        description: extra parameters for the server
> > +        example: -p 5223
> > +        optional: yes
> > +    - client_params:
> > +        description: extra parameters for the client
> > +        example: -p 5223 -u -b 10G
> > +        optional: yes
> > +data_files:
> > +    - chart_config.json
> > +    - fuego_test.sh
> > +    - parser.py
> > +    - spec.json
> > +    - criteria.json
> > +    - iperf-3.1.3-source.tar.gz
> > +    - reference.json
> > +    - test.yaml
> > --
> > 2.7.4
> 
> I'm fine with the new fields.  The schema for 'params' (with description, example, and optional)
> seems OK.
> 
> Thanks. applied.
>  -- Tim

Thanks,
Daniel





More information about the Fuego mailing list