[Fuego] [PATCH 4/5] iperf3: remove server initialization

Tim.Bird at sony.com Tim.Bird at sony.com
Tue Mar 20 03:58:02 UTC 2018


Patches 1 through 4 in this series look fine.  1-4 Applied.
 -- Tim


> -----Original Message-----
> From: Daniel Sangorrin
> 
> Killing and restarting the server could create race conditions
> when running the test at the same time on multiple boards.
> Instead we move the initialization to the Docker entrypoint
> (see Fuego commit)
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
>  engine/tests/Benchmark.iperf3/fuego_test.sh | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/engine/tests/Benchmark.iperf3/fuego_test.sh
> b/engine/tests/Benchmark.iperf3/fuego_test.sh
> index 4a6e98b..4c27ce1 100755
> --- a/engine/tests/Benchmark.iperf3/fuego_test.sh
> +++ b/engine/tests/Benchmark.iperf3/fuego_test.sh
> @@ -20,15 +20,6 @@ function test_run {
>          return 1
>      fi
>      echo "Using server ip address: $IPERF3_SERVER_IP"
> -
> -    # Check if the server ip belongs to us
> -    ROUTE=$(ip route get $IPERF3_SERVER_IP | cut -f 1 -d " ")
> -    if [ "$ROUTE" = "local" ]; then
> -        echo "Starting iperf3 server on localhost (SERVER IP:
> $IPERF3_SERVER_IP)"
> -        killall iperf3 2> /dev/null || true
> -        iperf3 -V -s -D $BENCHMARK_IPERF3_SERVER_PARAMS
> -    fi
> -
>      echo "Starting iperf3 client on the target (CLIENT IP: $IPADDR)"
>      cmd "cd $BOARD_TESTDIR/fuego.$TESTDIR; ./iperf3 -V -c
> $IPERF3_SERVER_IP -f M -J --logfile
> $BOARD_TESTDIR/fuego.$TESTDIR/output.json --get-server-output
> $BENCHMARK_IPERF3_CLIENT_PARAMS"
>      report "cat $BOARD_TESTDIR/fuego.$TESTDIR/output.json"
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list