[Fuego] [PATCH 4/4] LTP: print the timestamp when running one testset

Tim.Bird at sony.com Tim.Bird at sony.com
Tue Mar 20 04:56:29 UTC 2018


I'm OK with this one, but it does introduce a requirement to support
the 'date' command on the target, that is new for LTP.  I think this
is OK, but some very low-end systems might not have that command.

You should check for the 'date' command on the target board in test_pre_check(),
or have ltp_target_run.sh check for it, and not use it if it's not present.
(the second option is better, IMHO, unless you're going to add some tooling that will
depend on the date string being present in the logs).
 -- Tim

> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> bounces at lists.linuxfoundation.org] On Behalf Of Liu Wenlong
> Sent: Sunday, March 11, 2018 8:39 AM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 4/4] LTP: print the timestamp when running one
> testset
> 
> Why add the timestamp info?
> - Help us to check the test duration for each testset when running
>   multiple testsets at the same time.
> 
> Signed-off-by: Liu Wenlong <liuwl.fnst at cn.fujitsu.com>
> ---
>  engine/tests/Functional.LTP/ltp_target_run.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/engine/tests/Functional.LTP/ltp_target_run.sh
> b/engine/tests/Functional.LTP/ltp_target_run.sh
> index 3292a4b..17d633c 100755
> --- a/engine/tests/Functional.LTP/ltp_target_run.sh
> +++ b/engine/tests/Functional.LTP/ltp_target_run.sh
> @@ -23,7 +23,7 @@ echo "ltp_target_run: ${TESTS} | ${PTSTESTS} |
> ${RTTESTS}"
> 
>  # FIXTHIS: add -t option for limiting the duration of each test group
> execution
>  for i in ${TESTS}; do
> -    echo "ltp_target_run: doing test $i"
> +    echo "ltp_target_run: doing test $i ($(date))"
>      mkdir -p ${OUTPUT_DIR}/${i}
>      ./runltp -C ${OUTPUT_DIR}/${i}/failed.log \
>               -l ${OUTPUT_DIR}/${i}/result.log \
> @@ -39,13 +39,13 @@ export LOGFILE=${OUTPUT_DIR}/pts.log
>  # remove any previous posix results
>  test -e "${LOGFILE}" && rm "${LOGFILE}"
>  for i in ${PTSTESTS}; do
> -    echo "ltp_target_run: doing test $i" | tee -a $LOGFILE
> +    echo "ltp_target_run: doing test $i ($(date))" | tee -a $LOGFILE
>      # PTS scripts seem to have some bashims
>      /bin/bash ./bin/run-posix-option-group-test.sh $i
>  done
> 
>  for i in ${RTTESTS}; do
> -    echo "ltp_target_run: doing test $i"
> +    echo "ltp_target_run: doing test $i ($(date))"
>      /bin/bash ./testscripts/test_realtime.sh -t $i
>  done
>  [ -e testcases/realtime/logs ] && cat testcases/realtime/logs/*.log >
> ${OUTPUT_DIR}/rt.log
> --
> 2.7.4
> 
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list