[Fuego] [PATCH 2/3] ftc: gen-report: Make format for name of test report file

Tim.Bird at sony.com Tim.Bird at sony.com
Tue Mar 20 22:23:36 UTC 2018


> -----Original Message-----
> From: Hoang Van Tuyen
> 
> On 3/13/2018 5:16 PM, Hoang Van Tuyen wrote:
> > +    # always include "/" to make sure the test_file_name into report_dir
> > +    if fmt == "excel":
> > +        report_file = report_dir + "/" + test_file_name + "." + "xlsx"
> > +    else:
> > +        report_file = report_dir + "/" + test_file_name + "." + fmt
> Should use os.sep instead of "/" because on Windows OS, os.sep is "\"

There are a whole lot of forward slashes in the code, making running
this on Windows problematic.  Also, I think an environment in Windows
capable of running shell scripts (like Cygwin), will probably support
forward slash as a path delimiter.  I don't envision us running ftc
native on Windows any time soon.

However, I just added a patch with the change to os.sep, just
because...

Thanks,
 -- Tim



More information about the Fuego mailing list