[Fuego] [PATCH 05/10] kernel_build: remove paranoic shell checks

Tim.Bird at sony.com Tim.Bird at sony.com
Tue Mar 27 21:42:53 UTC 2018



> -----Original Message-----
> From: Daniel Sangorrin
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
>  engine/tests/Functional.kernel_build/fuego_test.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/engine/tests/Functional.kernel_build/fuego_test.sh
> b/engine/tests/Functional.kernel_build/fuego_test.sh
> index b88d07e..6090af4 100755
> --- a/engine/tests/Functional.kernel_build/fuego_test.sh
> +++ b/engine/tests/Functional.kernel_build/fuego_test.sh
> @@ -25,7 +25,7 @@ function test_pre_check {
>  }
> 
>  function test_build {
> -    if [ -z ${FUNCTIONAL_KERNEL_BUILD_CONFIG+x} ]; then
> +    if [ -z "$FUNCTIONAL_KERNEL_BUILD_CONFIG" ]; then
>          FUNCTIONAL_KERNEL_BUILD_CONFIG="defconfig"
>      fi
>      echo "Configuring kernel with $FUNCTIONAL_KERNEL_BUILD_CONFIG"
> @@ -33,11 +33,11 @@ function test_build {
> 
>      # Building
>      echo "Building Kernel"
> -    if [ -z ${FUNCTIONAL_KERNEL_BUILD_PARAMS+x} ]; then
> +    if [ -z "$FUNCTIONAL_KERNEL_BUILD_PARAMS" ]; then
>          FUNCTIONAL_KERNEL_BUILD_PARAMS="-j4 bzImage modules"
>      fi
> 
> -    if [ ! -z ${FUNCTIONAL_KERNEL_BUILD_PLATFORM+x} ]; then
> +    if [ ! -z "$FUNCTIONAL_KERNEL_BUILD_PLATFORM" ]; then
Thanks.  I wasn't a big fan of these old-style shell expansions $(foo+x).
This is easier to read.
 -- Tim

>            OLD_PLATFORM=$PLATFORM
>            PLATFORM=$FUNCTIONAL_KERNEL_BUILD_PLATFORM
>            source $FUEGO_RO/toolchains/tools.sh
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list