[Fuego] [PATCH 13/16] Move Selenium implicitly_wait() to SeleniumSession start

Guilherme Campos Camargo guicc at profusion.mobi
Thu Mar 29 00:08:29 UTC 2018


Remove it from SeleniumCommand.exec(), given that "once set, it will be
set for the life of the WebDriver object".

implictly_wait() documentation:
http://selenium-python.readthedocs.io/waits.html#implicit-waits

Signed-off-by: Guilherme Campos Camargo <guicc at profusion.mobi>
---
 engine/tests/Functional.fuegotest/test_run.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/engine/tests/Functional.fuegotest/test_run.py b/engine/tests/Functional.fuegotest/test_run.py
index f62ebc1..91d0666 100755
--- a/engine/tests/Functional.fuegotest/test_run.py
+++ b/engine/tests/Functional.fuegotest/test_run.py
@@ -41,7 +41,6 @@ class SeleniumCommand:
     def exec(self, selenium_ctx):
         self.driver = selenium_ctx.driver
         self.driver.refresh()
-        self.driver.implicitly_wait(3)
         LOGGER.debug('Executing Selenium Command \'%s\'',
                      self.__class__.__name__)
 
@@ -422,9 +421,10 @@ class SeleniumContainerSession():
         options.add_argument('window-size=1200x600')
 
         self.driver = webdriver.Chrome(chrome_options=options)
-        self.driver.get(self.root_url)
+        self.driver.implicitly_wait(3)
 
         self.driver.get(self.root_url)
+
         LOGGER.debug('Started a Selenium Session on %s', self.root_url)
         return True
 
-- 
2.16.2



More information about the Fuego mailing list