[Fuego] [PATCH 10/16] Write ok/fail on test report

Tim.Bird at sony.com Tim.Bird at sony.com
Fri Mar 30 22:58:24 UTC 2018



> -----Original Message-----
> From: Guilherme Campos Camargo
> 
> Remove the 'minimal test' that had been copied from an example test.
> 
> Signed-off-by: Guilherme Campos Camargo <guicc at profusion.mobi>
> ---
>  engine/tests/Functional.fuegotest/fuego_test.sh | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/engine/tests/Functional.fuegotest/fuego_test.sh
> b/engine/tests/Functional.fuegotest/fuego_test.sh
> index b4755bc..ee60c81 100755
> --- a/engine/tests/Functional.fuegotest/fuego_test.sh
> +++ b/engine/tests/Functional.fuegotest/fuego_test.sh
> @@ -1,7 +1,5 @@
>  #!/bin/bash
> 
> -set -e
> -
>  readonly fuego_release_dir=fuego-release
> 
>  function test_build {
> @@ -26,9 +24,13 @@ function test_build {
> 
>  function test_run {
>      sudo -n ${TEST_HOME}/test_run.py "${fuego_release_dir}/fuego"
> -    report "echo ok 1 minimal test on target"
> +    if [ "${?}" = 0 ]; then
> +        report "echo fuego-test: ok"
> +    else
> +        report "echo fuego-test: fail"
> +    fi

Please keep the output in TAP format, which should look like this:
    report "echo ok 1 fuego release test"
else
    report "echo not ok 1 fuego release test"

>  }
> 
>  function test_processing {
> -    log_compare "$TESTDIR" "1" "^ok" "p"
> +    log_compare "$TESTDIR" "1" "ok$" "p"
We're trying to stay with TAP format where possible.
This line can be left alone.

 -- Tim



More information about the Fuego mailing list