[Fuego] [PATCH 3/3] Add CheckScreenshot fuego_release_test dependencies

Gustavo Sverzut Barbieri barbieri at profusion.mobi
Sat May 5 19:54:25 UTC 2018


On Fri, May 4, 2018 at 5:22 PM, <Tim.Bird at sony.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Guilherme Campos Camargo
> > A new class of tests has been included in fuego_release_test. The
> > purpose of this new class is to compare screenshots.
> >
> > This patch adds the newly required dependencies: imagemagick and
> > python-pillow, that are used by CheckScreenshot.
> >
> > Signed-off-by: Guilherme Campos Camargo <guicc at profusion.mobi>
> > ---
> >  Dockerfile | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Dockerfile b/Dockerfile
> > index f148cf7..09e3c00 100644
> > --- a/Dockerfile
> > +++ b/Dockerfile
> > @@ -78,10 +78,13 @@ RUN apt-get update && \
> >          chromium \
> >          curl \
> >          gnupg2 \
> > +        imagemagick \
> >          python3 \
> >          python3-pip \
> > +        python3-pillow \
> >          software-properties-common && \
> > -    pip3 install \
> > +    rm -rf /var/lib/apt/lists/* && \
>
> This line kind of scares me.  What is this doing, and why?

basically this is the standard approach for debian + docker: install
then cleanup local caches as they just take space in the final image,
without much benefit (since "apt-get update" will regenerate those
files anyway).


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN, GTalk, FaceTime: barbieri at gmail.com
Skype: gsbarbieri
Mobile: +55 (16) 99354-9890


More information about the Fuego mailing list