[Fuego] [Question] Will new tests be welcome by Fuego

Wang, Mingyu wangmy at cn.fujitsu.com
Tue May 22 02:00:07 UTC 2018


Hi Tim

Thank you for you comment. And I've been used 'sh' instead of 'bash'.

-- Wangmy

-----Original Message-----
From: Tim.Bird at sony.com [mailto:Tim.Bird at sony.com] 
Sent: Saturday, May 19, 2018 10:12 AM
To: Wang, Mingyu/王 鸣瑜 <wangmy at cn.fujitsu.com>; fuego at lists.linuxfoundation.org
Subject: RE: [Question] Will new tests be welcome by Fuego



> -----Original Message-----
> From: Wang, Mingyu [mailto:wangmy at cn.fujitsu.com]
> Sent: Friday, May 18, 2018 1:47 AM
> To: Bird, Timothy <Tim.Bird at sony.com>; fuego at lists.linuxfoundation.org
> Subject: RE: [Question] Will new tests be welcome by Fuego
> 
> Hi Tim,
> 
> I have submited several busybox related test cases.  I would like you 
> to review them first.
> There are 89 busybox related test cases, and all test cases is placed 
> in testsuits directory.
> This time I only submitted 4 of them. I would like to modify the 
> remaining cases according to your opinion and  submit the rest of them step by step.

Here are the results for me running this on my beaglebone:
My comments are in ***comment*** marks.

...
##### doing fuego phase: run ########
WARNING: test log file parameter empty, so will use default #!/bin/bash for i in testsuits/*.sh; do
    sh $i
done
testsuits/busybox_ash.sh: 5: testsuits/busybox_ash.sh: expect: not found
*** my board doesn't have expect ***
testsuits/busybox_bunzip2.sh: 6: [: This is a test file: unexpected operator
*** maybe a shell syntax error? - I think a missing semi-colon. ***
bunzip2: test cases failed.
             total         used         free       shared      buffers
Mem:        508496        99328       409168            0          524
-/+ buffers:              98804       409692
Swap:            0            0            0
testsuits/busybox_free.sh: 5: [: 0: unexpected operator
*** I noticed you use `echo $?` in busybox_free.sh  You should just use "$?", and only use =, not == ***
free: test cases failed.
wget: bad port spec '192.168.7.1:'
ls: cannot access /home/test/: No such file or directory
wget: ls  /home/test/ failed.
*** this is the /home/test problem I mentioned in my other email ***
cat: /home/test/readme.txt: No such file or directory
wget: test cases failed.
rm: cannot remove `/home/test/readme.txt': No such file or directory a bin boot bootsave dev etc home lib
lost+found
media
mnt
opt
proc
root
run
sbin
selinux
srv
sys
tests
tmp
usr
var
work
*** this is from that stray 'ls' - what is this for? ***

##### doing fuego phase: post_test ######## Teardown board link ##### doing fuego phase: processing ######## ...

----
I noticed that all your test scripts use #!/bin/bash.  You should use #!/bin/sh as not every test machine will have bash.  Fuego tries not to rely on bash being on a target board.  I know you are invoking these with 'sh'
in busybox_test.sh, but someone might try to run these scripts standalone.

 -- Tim






More information about the Fuego mailing list