[Fuego] 答复: Some doubts about the check_measure

Zhong, Lu zhongl.fnst at cn.fujitsu.com
Thu Nov 8 03:13:07 UTC 2018


Hi
  I have updated my version of Fuego-core to the latest version, and it can compare threshold with 0.

Thanks
--zhong

 > > -----Original Message-----
> > From: Zhong, Lu
> >
> > In Benchmark.Dhrystone, according to "criteria.json",  if
> > Dhrystone.Score output value is greater than 0, the case will PASS.
> >
> > However, when we operate this case, the result of threshold
> > comparison(Contrast with 0) is "SKIP", which makes the case failed.
> >
> >
> >
> > So I have some doubts about the check_measure in " fuego-
> > core/engine/scripts/parser/common.py".
> >
> > In Commitid ffb027e, it refactors check_measure and add some code as
> > following:
> >
> > "
> >
> > ref_value = reference.get('value', None)
> >
> > +    if not ref_value:
> >
> > +        print("Error: criteria missing reference value - returning
> > + SKIP")
> >
> > +        return 'SKIP'
> >
> > "
> >
> > In this case, all of our output values cannot be compared with 0(direct skip).
> 
> The code no longer looks like this.  Please see commit 8e0f38312
> (https://bitbucket.org/tbird20d/fuego-core/commits/8e0f38312452189f15d8fd
> bb4928b4799cadecb4)
> 
> 
> > Can we compare threshold with 0 in fuego?
> 
> It should work in the latest master branch.  Please test with a 0-valued
> threshold, and let me know what happens.
>  -- Tim
> 
> >
> >
> > Thanks
> >
> >
> 
> 





More information about the Fuego mailing list