[Fuego] [PATCH 5/5] Functional.neon: change pre-check and build

Tim.Bird at sony.com Tim.Bird at sony.com
Fri Nov 9 04:27:40 UTC 2018



> -----Original Message-----
> From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM
> 
> detail: 1.modify system-acdir option to fix the problem of non-existent dir
>         2.delete 'automake -a' to fix build error
>         3.add lib check of libneon.so.27 and libproxy.so.1
I wish there was a bit more explanation of why libproxy.so.1 is needed here.

> 
> Signed-off-by: Qiu Tingting <qiutt at cn.fujitsu.com>
> ---
>  engine/tests/Functional.neon/fuego_test.sh | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/engine/tests/Functional.neon/fuego_test.sh
> b/engine/tests/Functional.neon/fuego_test.sh
> index 75e67b7..ddbb5d6 100755
> --- a/engine/tests/Functional.neon/fuego_test.sh
> +++ b/engine/tests/Functional.neon/fuego_test.sh
> @@ -1,8 +1,10 @@
>  tarball=neon-test.tar.bz2
> 
>  function test_pre_check {
> -    is_on_target libneon.so LIB_NEON /lib:/usr/lib:/usr/local/lib
> +    is_on_target libneon.so.27 LIB_NEON /lib:/usr/lib:/usr/local/lib
>      assert_define LIB_NEON
> +    is_on_target libproxy.so.1 LIB_PROXY /lib:/usr/lib:/usr/local/lib
> +    assert_define LIB_PROXY
Why is this needed.

>  }
> 
>  function test_build {
> @@ -11,11 +13,11 @@ function test_build {
>  	patch -p0 < pkgconfig.patch
>  	cd ./neon-0.30.1
>  	libtoolize --automake
> -	aclocal --system-acdir=${SDKROOT}usr/share/aclocal
> +	aclocal --system-acdir=${SDKROOT}/usr/share/aclocal
>  	autoreconf --verbose --install --force --exclude=autopoint -I macros
>  	autoconf
>  	autoheader
> -	automake -a
> +#	automake -a
>  	./configure --host=$PREFIX --with-libxml2 -with-expat --enable-
> shared --without-gssapi --with-ssl=gnutls CPPFLAGS="-
> DHAVE_GNUTLS_CERTIFICATE_SET_RETRIEVE_FUNCTION=1"
>  	make
>  	cd ./test
> --
> 2.7.4

I don't understand all of what you've done here.  But this test never worked
for me before. If these changes make the test work for you, then I guess
I will accept them.  Having the test work for someone is better than having
it work for no one.

Applied.

Thanks,
 -- Tim



More information about the Fuego mailing list