[Fuego] [PATCH 4/5] Functional.net-tools: add absolute path

[Daniel Sangorrin]

> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org
> <fuego-bounces at lists.linuxfoundation.org> On Behalf Of Qiu, Tingting
> Sent: Friday, November 9, 2018 3:10 PM
> To: Tim.Bird at sony.com
> Cc: fuego at lists.linuxfoundation.org
> Subject: Re: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path
> 
> Hi,Tim
> 
> > Hmm.  Do you have a board that doesn't have /sbin in the path
> > of the user used to perform tests?  Or is this something to do
> > with a different PATH in the profile for a non-interactive user?
> I have a board here with arp in /sbin, and not /usr/sbin.
> 
> >
> > Can you fix this in your board setup or configuration (on the board
> > itself), rather than here?
> OK, I will change my board to fix this.
> Thanks for your reply.

Another option is to use
http://fuegotest.org/wiki/function_is_on_target

Thanks,
Daniel
 
> Regards,
> Qiu Tingting
> 
> > -----Original Message-----
> > From: Tim.Bird at sony.com [mailto:Tim.Bird at sony.com]
> > Sent: Friday, November 09, 2018 1:34 PM
> > To: Qiu, Tingting/仇 婷婷; fuego at lists.linuxfoundation.org
> > Subject: RE: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path
> >
> >
> > > -----Original Message-----
> > > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM
> > >
> > > Add absolute path to fix the problem of not finding cmd(e.g. arp).
> > >
> > > Signed-off-by: Qiu Tingting <qiutt at cn.fujitsu.com>
> > > ---
> > >  engine/tests/Functional.net-tools/fuego_test.sh | 14 +++++++-------
> > >  1 file changed, 7 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/engine/tests/Functional.net-tools/fuego_test.sh
> > > b/engine/tests/Functional.net-tools/fuego_test.sh
> > > index 06225fc..6f75799 100755
> > > --- a/engine/tests/Functional.net-tools/fuego_test.sh
> > > +++ b/engine/tests/Functional.net-tools/fuego_test.sh
> > > @@ -1,11 +1,11 @@
> > >  function test_run {
> > > -    report "if arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi;
> > \
> > > -    if hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; \
> > > -    if ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; \
> > > -    if ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; \
> > > -    if iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; \
> > > -    if netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; \
> > > -    if route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi"
> > > +    report "if /sbin/arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL';
> > fi; \
> > The 'arp' on my minnowboard is in /usr/sbin.
> >
> > > +    if /bin/hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi;
> > \
> > > +    if /sbin/ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi;
> > \
> > > +    if /sbin/ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi;
> > \
> > > +    if /sbin/iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi;
> > \
> > > +    if /bin/netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi;
> > \
> > > +    if /sbin/route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi"
> > >  }
> > >
> > >  function test_processing {
> > > --
> > > 2.7.4
> >
> > Hmm.  Do you have a board that doesn't have /sbin in the path
> > of the user used to perform tests?  Or is this something to do
> > with a different PATH in the profile for a non-interactive user?
> >
> > Can you fix this in your board setup or configuration (on the board
> > itself), rather than here?
> >
> > I have a board here with arp in /usr/sbin, and not /sbin, so this
> > would cause this test to fail on my machine.
> >
> > So, sorry, but this is not applied.
> >  -- Tim
> >
> >
> 
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego