[Fuego] 答复: [PATCH] Solve-the-error-of-drawing-when-bt-in-criteria

Zhong, Lu zhongl.fnst at cn.fujitsu.com
Thu Nov 15 05:58:34 UTC 2018


Hi 

The comment "FIXTHIS" already existed in code, so we didn't delete it.
But as you said , indeed, the code already does what the FIXTHIS describes, I agree that make it be a normal comment here.

Thanks

Zhong.


> > -----Original Message-----
> > From: Zhong Lu on Tuesday, November 13, 2018 5:10 PM
> >
> > details:get "self.op" failed because the parts has been changed by
> > "parts = self.tguid.split(".")"
> >
> > Signed-off-by: Zhong Lu <zhongl.fnst at cn.fujitsu.com>
> > ---
> >  engine/scripts/parser/prepare_chart_data.py | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/engine/scripts/parser/prepare_chart_data.py
> > b/engine/scripts/parser/prepare_chart_data.py
> > index f44fe36..da1fafe 100644
> > --- a/engine/scripts/parser/prepare_chart_data.py
> > +++ b/engine/scripts/parser/prepare_chart_data.py
> > @@ -70,6 +70,11 @@ class flat_entry:
> >              self.tguid = parts[6]
> >              self.ref = parts[7]
> >              self.result = parts[8]
> > +            # FIXTHIS - old files might not have the 'op' field, parse it
> separately
> > +            try:
> > +                self.op = parts[9]
> > +            except:
> > +                pass
> >
> >              # break apart tguid
> >              parts = self.tguid.split(".") @@ -90,12 +95,6 @@ class
> > flat_entry:
> >          except:
> >              pass
> >
> > -        # FIXTHIS - old files might not have the 'op' field, parse it separately
> > -        try:
> > -            self.op = parts[9]
> > -        except:
> > -            pass
> > -
> >      def __str__(self):
> >          return "%s %s %s %s %s %s %s %s %s\n" % \
> >                  (self.board, self.testname, self.spec,
> > self.build_number,
> > --
> > 2.7.4
> 
> Looks good.  Thanks for the fix.
> 
> I applied it, then did some testing, and noticed the FIXTHIS comment.
> I don't think anything needs to be fixed here, does it?
> I think the code does what the FIXTHIS describes needs to be done.
> 
> I think that can be a normal comment (without the FIXTHIS tag)
> 
> Please let me know what you think.
>  -- Tim
> 
> 





More information about the Fuego mailing list