[Fuego] [PATCH 12/15] svsematest: fix unavailable cpu num of PARAMS

Tim.Bird at sony.com Tim.Bird at sony.com
Thu Nov 15 22:45:58 UTC 2018


Same question about this one as ptsematest.

Please explain better.  I don't understand how taking the number of
processors from /proc/cpuinfo is going to omit processors that
are not working.

I guess I don't understand the different algorithms that are being
used by the RT test programs (ptsematest and svsematest) and
the /proc/cpuinfo scan, that would yield a different numbers.

What is the behavior that is faulty, if you don't use the -t parameter
to these tests?
 -- Tim


> -----Original Message-----
> From: fuego-bounces at lists.linuxfoundation.org [mailto:fuego-
> bounces at lists.linuxfoundation.org] On Behalf Of Qiu Tingting
> Sent: Wednesday, November 14, 2018 8:26 PM
> To: fuego at lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 12/15] svsematest: fix unavailable cpu num of
> PARAMS
> 
> Cmd svsematest has -t num parameter.
> When cpu num is not setted, default value is max num of cpu.
> Maybe some of cpu is not working, so we should set the available cpu num.
> 
> Signed-off-by: Qiu Tingting <qiutt at cn.fujitsu.com>
> ---
>  engine/tests/Benchmark.svsematest/fuego_test.sh | 2 +-
>  engine/tests/Benchmark.svsematest/spec.json     | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/engine/tests/Benchmark.svsematest/fuego_test.sh
> b/engine/tests/Benchmark.svsematest/fuego_test.sh
> index f2ebd18..2988cd4 100755
> --- a/engine/tests/Benchmark.svsematest/fuego_test.sh
> +++ b/engine/tests/Benchmark.svsematest/fuego_test.sh
> @@ -21,5 +21,5 @@ function test_run {
>      # The number for getting the lines depends on the cpu number of target
> machine.
>      target_cpu_number=$(cmd "cat /proc/cpuinfo | grep processor | wc -l")
>      getting_line_number=$(( $target_cpu_number + $target_cpu_number ))
> -    report "cd $BOARD_TESTDIR/fuego.$TESTDIR; ./svsematest
> $BENCHMARK_SVSEMATEST_PARAMS | tail -$getting_line_number"
> +    report "cd $BOARD_TESTDIR/fuego.$TESTDIR; ./svsematest
> $BENCHMARK_SVSEMATEST_PARAMS$target_cpu_number | tail -
> $getting_line_number"
>  }
> diff --git a/engine/tests/Benchmark.svsematest/spec.json
> b/engine/tests/Benchmark.svsematest/spec.json
> index 00e77c1..e814600 100644
> --- a/engine/tests/Benchmark.svsematest/spec.json
> +++ b/engine/tests/Benchmark.svsematest/spec.json
> @@ -2,13 +2,13 @@
>      "testName": "Benchmark.svsematest",
>      "specs": {
>          "default": {
> -            "PARAMS": "-a -t -p99 -i100 -d25 -l10000"
> +            "PARAMS": "-a -p99 -i100 -d25 -l10000 -t"
>          },
>          "latest": {
>              "PER_JOB_BUILD": "true",
>              "gitrepo": "https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git",
>              "gitref": "unstable/devel/latest",
> -            "PARAMS": "-a -t -p99 -i100 -d25 -l10000"
> +            "PARAMS": "-a -p99 -i100 -d25 -l10000 -t"
>          }
>      }
>  }
> --
> 2.7.4
> 
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list