[Fuego] [QUESTION] bc : problem occurs when adding test case to bc

[Wang, Mingyu]

Hi Tim

>If this is the problem, then it can be solved multiple ways:
>1) set Rebuild=true, in the job definition, for bc You can set this, and build the job once, and then 
>you should be able to reset it to false.  
>2) remove the build directory manually yourself.  This can be done with the following command 
>executed inside the docker container:
>rm -rf /fuego-rw/buildzone/myboard.default.Functional.bc-test

I have tried these two ways, and all can successfully unzip the files and test them.
Thank you for your help.

>Daniel just recently added a feature to record the md5sum for tarballs.
>It would be good to add some support to print a warning, or to automatically remove the old build 
>directory, and re-unpack the tarball, if the TESTSUITE_VERSION of the tarball is different from the 
>one in the build directory.
I'd like to learn the relevant code and try to modify it.
In the process, if there are any problems, I'll ask you again ^_^

by Wangmy

-----Original Message-----
From: Tim.Bird at sony.com [mailto:Tim.Bird at sony.com] 
Sent: Wednesday, October 10, 2018 3:15 AM
To: Wang, Mingyu/王 鸣瑜 <wangmy at cn.fujitsu.com>; fuego at lists.linuxfoundation.org
Subject: RE: [Fuego] [QUESTION] bc : problem occurs when adding test case to bc



> -----Original Message-----
> From: Wang, Mingyu
> 
> Hi Tim,
> 
> I found a problem when I added test case to the existing test set 
> Functional.bc.
> 
> 
> 
> I don't know if it's a problem of myself, or if it's a bug of fuego, 
> I'll describe the steps and phenomena as follows:
> 
> 1.  Unzip the existing test set bc-script.tar.gz, add a new test file 
> bc-file.sh, and recompress
> 
> 2.  modify the contents of test_deploy in fuego_test.sh as follows:
> 
> Function test_deploy {
> 
>     ls .                            -- > for debugging
> 
>     pwd                        -- > for debugging
> 
>     put bc-device.sh $BOARD_TESTDIR/fuego.$TESTDIR
> 
>     put bc-file.sh $BOARD_TESTDIR/fuego.$TESTDIR
> 
> }
> 
> 3. running test, but it cannot find file bc-file.sh
> 
> 
> 
> Please refer to bc_log.txt for details.

The log doesn't have the build phase, which might have some additional needed data.

If you look at the log, when the 'ls' is done, bc-file.sh is not present in the build directory.
That would explain why the later 'scp' operation is failing.

There could be a couple of reasons for this, but the most likely is that Fuego thinks the test has already been built successfully (determined due to the presence of the file 'fuego_test_successfully_built' file in the build directory).

In this case, it won't re-unpack the tar file.

If this is the problem, then it can be solved multiple ways:
1) set Rebuild=true, in the job definition, for bc You can set this, and build the job once, and then you should be able to reset it to false.  
2) remove the build directory manually yourself.  This can be done with the following command executed inside the docker container:
rm -rf /fuego-rw/buildzone/myboard.default.Functional.bc-test

For either of these you should turn on debugging to verify that during the build phase the new tarball is unpacked into the build directory.

Can you try those and let me know if that fixes your problem?

Daniel just recently added a feature to record the md5sum for tarballs.
It would be good to add some support to print a warning, or to automatically remove the old build directory, and re-unpack the tarball, if the TESTSUITE_VERSION of the tarball is different from the one in the build directory.

Let me know if you'd like to work on this.
 -- Tim