[Fuego] [PATCH] Benchmark.bonnie: with make mode

Tim.Bird at sony.com Tim.Bird at sony.com
Sat Sep 1 01:07:04 UTC 2018


See comments inline below.

> -----Original Message-----
> From Zhong Lu
> 
> Details: only do dynamic make, as board lack of static library.

I don't want to make this change global.  All of the toolchains
for boards in my lab support making static libraries:

For example:
# find . -name "bonnie++" | grep ./B | xargs file
Benchmark.bonnie-x86_64/bonnie++:       ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), statically linked
Benchmark.bonnie-debian-armhf/bonnie++: ELF 32-bit LSB executable, ARM, EABI5 version 1 (GNU/Linux), statically linked
Benchmark.bonnie-poky-aarch64/bonnie++: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked

However, I see the problem if your toolchain does not support this.
See below for the description of my solution.

> 
> Signed-off-by: Zhong Lu <zhongl.fnst at cn.fujitsu.com>
> ---
>  engine/tests/Benchmark.bonnie/fuego_test.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/engine/tests/Benchmark.bonnie/fuego_test.sh
> b/engine/tests/Benchmark.bonnie/fuego_test.sh
> index 8711750..df98143 100755
> --- a/engine/tests/Benchmark.bonnie/fuego_test.sh
> +++ b/engine/tests/Benchmark.bonnie/fuego_test.sh
> @@ -15,7 +15,7 @@ function test_build {
>      if [ -z "$PROGRAM_BONNIE" ]; then
>          patch <$TEST_HOME/fix-nogroup-gid-if.patch
>          ./configure --host=$HOST --build=`uname -m`-linux-gnu;
> -        LFLAGS="-static" make
> +        make
>      else
>          echo "Skipping build phase, bonnie++ is already on the target"
>      fi
> --


I have added a new variable to Fuego called "FUEGO_BUILD_FLAGS".

It is documented here:
http://fuegotest.org/wiki/FUEGO_BUILD_FLAGS

Basically, you can add it to your board file, or to a toolchain ($PLATFORM-tools.sh) file.
If it includes the string "no_static", then for that board, or for that toolchain (respectively),
Fuego will build bonnie dynamically.  The goal would be to have other tests that try to
build statically also use this flag, to avoid that behavior when the toolchain doesn't support
it.

I think this will solve your problem.  You should be able to put:
FUEGO_BUILD_FLAGS="no_static"
in your board file, and bonnie will build a dynamically-linked rather than statically-linked
program.

I pushed a commit to this to master.  Please try it out and let me know if it solves your
problem.
 -- Tim



More information about the Fuego mailing list