[Fuego] [PATCH 01/11] rebuild: add if_source_changed flag

Tim.Bird at sony.com Tim.Bird at sony.com
Fri Sep 28 06:36:20 UTC 2018



> -----Original Message-----
> From: Daniel Sangorrin 
> > Does the ftc run-test code depend on this, or can I take them out of order?
> > I'd like to apply that patch, but consider this one a bit longer.
> 
> No, it doesn't depend on this.

OK - I applied it, but had some problems with logging, and ended up
reverting the conversion to the python logger module for 'ftc run-test'.
I found some other bugs with handling stdout and calling into the container,
that I also made fixes for.

My main reason for pulling out the python logging module conversion is
that that module is very complicated (ie hard to debug, IMO) and didn't
really match what we were using it for.  The logging data should be a direct
pass-through of what goes into the log, to the ftc stdout.  We shouldn't be
adding any additional fields or adding levels or the like.  Whatever main.sh
produces as stdout, ftc should also.  So I didn't want the extra complexity.

It's been a long debug session, so I'll respond to the other issues about
the if_source_changed change  tomorrow.  But the code with the
'Jenkins calls ftc run-test' is now applied and pushed.  Please give it a whirl.

And thanks very much for the work!  I've been wanting to convert over to
a command-line oriented approach for some time, and this is great stuff.
In particular, the separation of actions based on caller type is really good.

Regards,
 -- Tim



More information about the Fuego mailing list