[Fuego] [PATCH 1/2] common: remove redundant devlog reference

[daniel.sangorrin at toshiba.co.jp]

> -----Original Message-----
> From: Tim.Bird at sony.com <Tim.Bird at sony.com>
> Sent: Saturday, January 12, 2019 7:51 AM
> To: sangorrin daniel(サンゴリン ダニエル ○ＳＷＣ□ＯＳＴ) <daniel.sangorrin at toshiba.co.jp>;
> fuego at lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH 1/2] common: remove redundant devlog reference
> 
> 
> 
> > -----Original Message-----
> > From: daniel.sangorrin at toshiba.co.jp
> >
> > > -----Original Message-----
> > > From: Tim.Bird at sony.com <Tim.Bird at sony.com>
> > > Sent: Friday, January 11, 2019 9:35 AM
> > > To: sangorrin daniel(サンゴリン ダニエル ○ＳＷＣ□ＯＳＴ)
> > <daniel.sangorrin at toshiba.co.jp>;
> > > fuego at lists.linuxfoundation.org
> > > Subject: RE: [Fuego] [PATCH 1/2] common: remove redundant devlog
> > reference
> > >
> > > Look good.
> > >
> > > Applied to my 'next' branch.  My plan is to pull "obviously-safe" or bugfix
> > patches
> > > from 'next' to 'master' periodically.  But things will start by going to the
> > 'next'
> > > branch first.
> >
> > Yeah, that's a good idea. The ideal method is to have a Fuego test for each
> > pull.
> >
> > By the way, I noticed that there is a mismatch between what we are
> > packaging in frp and what the run.json declares as attachments.
> 
> Yeah. Right now, the function do_package_run just hardcodes the list of
> extra files:
> 
>     copy2(run.get_testlog_path(), tmp_run_dir+"/testlog.txt")
>     copy2(run.get_devlog_path(), tmp_run_dir+"/devlog.txt")
>     copy2(run.get_systemlog_path("before"), tmp_run_dir+"/syslog.before.txt")
>     copy2(run.get_systemlog_path("after"), tmp_run_dir+"/devlog.after.txt")
>     copy2(run.get_consolelog_path(), tmp_run_dir+"/consolelog.txt")
>     copy2(run.get_buildxml_path(), tmp_run_dir+"/build.xml")
> 
> This is from the section of code where we populate the temp dir.
> for creating the run package.
> 
> We should fix that by parsing the run.json for the attachment list.

I just sent to you a patch that parses the run.json instead. Let me know what you think please.

Regards,
Daniel


>   -- Tim