[Fuego] [PATCH 3/3] install-debian: add -x because we dont use docker

Tim.Bird at sony.com Tim.Bird at sony.com
Wed Mar 13 23:16:38 UTC 2019


See comments below.

> -----Original Message-----
> From: Daniel Sangorrin
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin at toshiba.co.jp>
> ---
>  install-debian.sh | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/install-debian.sh b/install-debian.sh
> index 1597535..62bf799 100755
> --- a/install-debian.sh
> +++ b/install-debian.sh
> @@ -232,8 +232,8 @@ ln -s /fuego-ro/scripts/fuego-lava-target-teardown
> /usr/local/bin
>  #
> ==========================================================
> ====================
>  echo "Run 'service netperf start' to start a netperf server"
>  echo "Run 'iperf3 -V -s -D -f M' to start an iperf3 server"
> -echo "Run 'ftc list-boards' to see the available boards"
> -echo "Run 'ftc list-tests' to see the available tests"
> -echo "Run 'ftc run-test -b local -t Functional.hello_world' to run a hello
> world"
> -echo "Run 'ftc run-test -b local -t Benchmark.Dhrystone -s 500M' to run
> Dhrystone"
> -echo "Run 'ftc gen-report' to get results"
> +echo "Run 'ftc -x list-boards' to see the available boards"
> +echo "Run 'ftc -x list-tests' to see the available tests"
> +echo "Run 'ftc -x run-test -b local -t Functional.hello_world' to run a hello
> world"
> +echo "Run 'ftc -x run-test -b local -t Benchmark.Dhrystone -s 500M' to run
> Dhrystone"
> +echo "Run 'ftc -x gen-report' to get results"
Ugh.  This inconsistency is ugly.  And I don't think these instructions
will actually work, will they?  I thought 'ftc -x' always required a '-c <confpath>'
to indicate the path to the configuration file.  See the FIXTHIS on line 4950
of 'ftc'.

For some of these, it would be better to just run them externally always.
'ftc list-boards' , 'ftc list-tests' fall in that category.

Here's how I'd like 'ftc run-test' to work:
'ftc run-test' should be run internally if there is a docker container present,
and externally if not (allowing the user to override and force it to run
externally even if there is a container present, using the '-x' argument.)

Can we reliably detect that a Fuego docker container is running?
We seem to have some code for this in 'container_command()'.

I think the logic I'll use here is as follows:
 - if we're outside the container, and there exists /fuego-ro/conf/fuego.conf, then
    if there is no container running, then execute the command external (don't require the '-x' flag)

I'll put some code in ftc to do this, which should allow us to not require the '-x' flag
for native use of ftc.  Let me know what you think.
 -- Tim

P.S.  This patch is not applied.

> --
> 2.7.4
> 
> _______________________________________________
> Fuego mailing list
> Fuego at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego


More information about the Fuego mailing list