[Fuego] Patch for Functional.check_mounts

[Kumar T]

Hi Tim,

         I have restructured the code as per your suggestions. I have taken
one of your patch as reference as created this "check_mounts" test cases
without using C code.  Fixed all the review comments.

        Please find the attached PATCH and other source files.
        Could you please review this patch.

Thanks,
Kumar.




On Tue, 3 Dec 2019 at 18:13, Kumar T <kumar.hcl.ers.epl at gmail.com> wrote:

> Hi Tim,
>
> Thanks a lot for your time and review comments.
>
> Apologies for the basic mistakes which I have done. I will correct these
> kinds of mistakes from upcoming patches.
>
> > After considering the issue, I think it would be better to structure the
> fs_test.c
> > code as a tool that takes two files and compares them
> > (kind of like diff, but allowing out-of-order lines).
>
> > Instead of hard-coding the filenames, please use 2 filenames that are
> passed
> > on the command line.
>
>    I will structure the fs_test.c code as tool that takes two files as
> command line arguments and compares them.
>    Will work on those review comments.
>
> > This will cause the internal code in Fuego that unpacks the source into
> the
> > build directory to copy the contents of the test's home directory there.
> > The build will then proceed as usual.
>
> > This will allow me to code review the source code for compiled portions
> > of the test, along with the fuego_test.sh, spec.json, and other
> Fuego-specific
> > test materials.
>
> > Please try this out, and let me know if you see any problems.
>
>   I will check and update you on this.
>
> Thanks,
> Kumar.
>
> On Mon, 2 Dec 2019 at 19:19, <Tim.Bird at sony.com> wrote:
>
>>
>>
>> > -----Original Message-----
>> > From: Tim.Bird at sony.com
>> >
>> > > -----Original Message-----
>> > > From: Kumar T [mailto:kumar.hcl.ers.epl at gmail.com]
>> > I plan to add a feature to Fuego to support an unpack operation for
>> "local"
>> > files (source files
>> > that are in the test directory - where the fuego_test.sh file
>> resides).  I'd like
>> > to use this test
>> > as a test case for that new feature.  I'll let you know the details of
>> when this
>> > feature is completed.
>>
>>
>> OK - I have added the feature to Fuego, and checked it into the master
>> branch.
>>
>> Now, instead of using the 'tarball' variable to specify the compiled code
>> for a test,
>> you can place the materials to be compiled directly into the test's home
>> directory
>> (e.g. you can put fs_test.c, the Makefile, and the README.md into
>> fuego-core/tests/Functional.check_mounts).
>>
>> Inside the fuego_test.sh, instead of using a 'tarball=' line, put a line
>> like the
>> following at the top of the file:
>> local_source=1
>>
>> This will cause the internal code in Fuego that unpacks the source into
>> the
>> build directory to copy the contents of the test's home directory there.
>> The build will then proceed as usual.
>>
>> This will allow me to code review the source code for compiled portions
>> of the test, along with the fuego_test.sh, spec.json, and other
>> Fuego-specific
>> test materials.
>>
>> Please try this out, and let me know if you see any problems.
>>  -- Tim
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/fuego/attachments/20200109/b5a1e854/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-check_mounts-PATCH-1-1.patch
Type: text/x-patch
Size: 5501 bytes
Desc: not available
URL: <http://lists.linuxfoundation.org/pipermail/fuego/attachments/20200109/b5a1e854/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fuego_test.sh
Type: application/x-shellscript
Size: 2881 bytes
Desc: not available
URL: <http://lists.linuxfoundation.org/pipermail/fuego/attachments/20200109/b5a1e854/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.yaml
Type: application/x-yaml
Size: 391 bytes
Desc: not available
URL: <http://lists.linuxfoundation.org/pipermail/fuego/attachments/20200109/b5a1e854/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: spec.json
Type: application/json
Size: 153 bytes
Desc: not available
URL: <http://lists.linuxfoundation.org/pipermail/fuego/attachments/20200109/b5a1e854/attachment.json>