[Fuego] Please switch server to fuegotest.org (was RE: poll request scheduling)

[Tim.Bird at sony.com]

Hey everyone,

I'm back from vacation.  Sorry this took so long to respond to,
but I was away from work since Dec. 22.  Please see my comments
inline below.

> -----Original Message-----
> From: Pooja Sanjay More <pooja.sm at pathpartnertech.com>
> 
> Hi Tim,
> 
> We checked with the IT team on the result upload issue and it was indeed a firewall
> configuration which was blocking it. This issue has been resolved now and we have
> successfully verified the result object updates on the server.

That is very good to hear!  Thanks for getting this resolved on your end.

> 
> 
> Logs for a test :
> 
> 
> root at cpu-366U:~# ftc put-request pptlab:rpi Functional.hello_world
> Request was accepted by the server.
> request_id=request-2020-12-24_12:39:23.93-pptlab:rpi
> 
> root at cpu-366U:~# ftc run-request --put-run request-2020-12-24_12:39:23.93-pptlab:rpi
> Trying to get request 'request-2020-12-24_12:39:23.93-pptlab:rpi' from server
> Executing test Functional.hello_world on board rpi (using spec default)
> Running test 'Functional.hello_world' on board 'rpi' using spec 'default'
> ===== doing fuego phase: pre_test =====
> ===== doing fuego phase: build =====
> The test is already built
> Fuego test_build duration=0 seconds
> ===== doing fuego phase: deploy =====
> ===== doing fuego phase: snapshot =====
> Firmware revision: 5.4.83-v7-52+
> ===== doing fuego phase: run =====
> -------------------------------------------------
> Hello World!
> 
> This is a test program, to demonstrate test success and failure
> Test result: SUCCESS
> -------------------------------------------------
> ===== doing fuego phase: post_test =====
> ===== doing fuego phase: processing =====
> log_compare: pattern 'SUCCESS' found 1 times (expected greater or equal than 1)
> chart config not found. Using default values.
> Fuego: requested test phases complete!
> Packaging run 'Functional.hello_world-default-130-rpi'
> run/
> run/machine-snapshot.txt
> run/syslog.before.txt
> run/devlog.txt
> run/testlog.txt
> run/run.json
> run/syslog.after.txt
> run/prolog.sh
> run/spec.json
> run/build.xml
> run/consolelog.txt
> Run packaged successfully, and is at: /tmp/run-Functional.hello_world-default-130-on-pptlab:rpi.frp
> Run package run-Functional.hello_world-default-130-on-pptlab:rpi.frp was accepted by the server.
> Run Functional.hello_world-default-130-rpi put to server

This looks good.

> 
> Fserver Output:
> 
> 
> 
> 
> We ran multiple tests and found that when there are tests which do not have test.yaml files
> give an error for  "eprint".
> 
> 
> 
> 
> 
> eprint() was not defined in ftc. We added it to ftc then it is working fine.
> 
> Changes in ftc:
> 
> diff --git a/scripts/ftc b/scripts/ftc
> index ae9ab2f..e70847d 100755
> --- a/scripts/ftc
> +++ b/scripts/ftc
> @@ -616,6 +616,9 @@ def wprint(msg):
>      global ll_warning
>      if ll_warning:
>          print("### WARNING: " + msg)
> +# always print errors
> +def eprint(msg):
> +    print("!!! ERROR: " + msg)
> 
>  class config_class:
>      def __init__(self, config_path):
> 
> Patch file is attached below.

I applied the patch.  It was not a well-formed patch for integration with
the project.  It was missing the author, commit text, signed-off-by line
and other meta-information required for a good commit.

I added this material, and added my own "Signed-off-by" line.  Please
note that I added a "Signed-off-by" line for you (Pooja).  Please let
me know if there is any problem with this.  Since the code looks like it
was taken from parser/common.py, I guessed that it was OK to add
your signed-off-by for the patch.

I found some other bugs in my testing, and added some other patches.
These have all been pushed to the master branch on bitbucket.

Please 'git pull' the latest material, and let me know if you see any problems.

It is really nice to get these bugs fixed.  Thanks
for the testing and the patch!!

I have some other comments that I'll put in another thread.

Thanks,
 -- Tim