[PATCH 00/34] AMD IOMMU driver

Joerg Roedel joerg.roedel at amd.com
Fri Jun 27 03:15:19 PDT 2008


Hi Ingo,

On Fri, Jun 27, 2008 at 12:07:51PM +0200, Ingo Molnar wrote:
> 
> -tip testing found a build failure with:
> 
> arch/x86/kernel/amd_iommu_init.c:247: warning: 'struct acpi_table_header' declared inside parameter list
> arch/x86/kernel/amd_iommu_init.c:247: warning: its scope is only this definition or declaration, which is probably not what you want
> arch/x86/kernel/amd_iommu_init.c: In function 'find_last_devid_acpi':
> arch/x86/kernel/amd_iommu_init.c:257: error: dereferencing pointer to incomplete type
> 
>   http://redhat.com/~mingo/misc/config-Fri_Jun_27_10_29_06_CEST_2008.bad
> 
> this is due to !CONFIG_ACPI.
> 
> since AMD IOMMU discovery depends on ACPI anyway, i've fixed this in the 
> Kconfig space. (Eventually, if you want to make it directly discoverable 
> via the PCI space in the future, you might want to fix this dependency.)
> 
> i've pushed out the fix below into -tip.

Thank you for your testing and the fixes. I will test the result from
your tree.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy



More information about the iommu mailing list