[PATCH 02/34] AMD IOMMU: add header file for driver data structures and defines

Ingo Molnar mingo at elte.hu
Mon Jun 30 05:22:08 PDT 2008


* FUJITA Tomonori <fujita.tomonori at lab.ntt.co.jp> wrote:

> > > > Signed-off-by: Joerg Roedel <joerg.roedel at amd.com>
> > > > ---
> > > >  include/asm-x86/amd_iommu_types.h |  242 +++++++++++++++++++++++++++++++++++++
> > > >  1 files changed, 242 insertions(+), 0 deletions(-)
> > > >  create mode 100644 include/asm-x86/amd_iommu_types.h
> > > 
> > > Is necessary to make this file visible to everyone by putting this in
> > > include/asm?
> > 
> > The alternative was to put this file in arch/x86/kernel/. But I don't
> > think its the right place for include files. We have include/ for that.
> 
> Hmm, really? It's the right thing in the SCSI subsystem at least. You 
> don't need to put a header file having only private stuff in include/.

it's OK to have it in include/asm-x86/ (in fact i'd prefer it to stay 
there). It includes hardware API details, etc.

	Ingo


More information about the iommu mailing list