[PATCHv2] iommu/arm-smmu: Make remove callback message more informative
robin.murphy at arm.com
Thu May 7 10:33:38 UTC 2020
On 2020-05-07 11:04 am, Sai Prakash Ranjan wrote:
> On 2020-05-07 05:40, Doug Anderson wrote:
>> On Thu, Apr 23, 2020 at 7:35 AM Doug Anderson <dianders at chromium.org>
>>> On Thu, Apr 23, 2020 at 2:55 AM Sai Prakash Ranjan
>>> <saiprakash.ranjan at codeaurora.org> wrote:
>>> > Currently on reboot/shutdown, the following messages are
>>> > displayed on the console as error messages before the
>>> > system reboots/shutdown as part of remove callback.
>>> > On SC7180:
>>> > arm-smmu 15000000.iommu: removing device with active domains!
>>> > arm-smmu 5040000.iommu: removing device with active domains!
>>> > Make this error message more informative and less scary.
>>> > Reported-by: Douglas Anderson <dianders at chromium.org>
>>> > Suggested-by: Robin Murphy <robin.murphy at arm.com>
>>> > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan at codeaurora.org>
>>> > ---
>>> > drivers/iommu/arm-smmu.c | 2 +-
>>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>>> Reviewed-by: Douglas Anderson <dianders at chromium.org>
>> Is this patch waiting on anything in particular now? Do we need
>> reviews from Robin and/or Will?
> Waiting for their reviews as they are the maintainers/reviewers :)
Sorry, this did register at the time, I just felt that it's a bit
redundant to give a review tag to say "yes, this is exactly what I
That said, I do wish I hadn't forgotten about the dev_notice message
level, but I think that lies over in the conceptual purity corner rather
than making any practical difference, so I'm still OK with the patch
p.s. whoever has this entry in their address book for the IOMMU list
"list at 263.net:IOMMU DRIVERS <iommu at lists.linux-foundation.org>, Joerg
Roedel <joro at 8bytes.org>," <iommu at lists.linux-foundation.org>
it really messes up Thunderbird's ability to generate working headers
for a reply ;)
More information about the iommu