[Ksummit-discuss] Should .c files be discouraged from #including UAPI headers directly?

Jamal Hadi Salim jhs at mojatatu.com
Wed Aug 6 16:11:11 UTC 2014


On 08/06/14 10:45, Greg KH wrote:
> On Wed, Aug 06, 2014 at 12:28:43PM +0100, David Howells wrote:
>
>>
>> 	#include <uapi/linux/psci.h>
>>
>> given that appropriate -I flags are supplied such that they'll fall back to
>> the UAPI header if a kernel-internal header does not exist?
>
> Why does it matter?  What works "better" if a .c file doesn't include
> the uapi.h file?
>


IMO, it is more intuitive to have an explicit uapi/
Issue i came across recently:
Old tutorials floating around specify a tc action module should
stash the user header in linux/tc_act - which would work
given current makefiles; but that is not what we want them to do
given iproute2 picks headers off uapi/linux
We cant fix old floating tutorials but by fixing the code to point
to the correct header location we are essentially documenting.

cheers,
jamal


More information about the Ksummit-discuss mailing list