[Ksummit-discuss] [TOPIC] Encouraging more reviewers

Rafael J. Wysocki rjw at rjwysocki.net
Mon May 26 12:38:18 UTC 2014


On Saturday, May 24, 2014 10:15:52 PM Bjorn Helgaas wrote:
> On Sat, May 24, 2014 at 11:31 AM, James Bottomley
> <James.Bottomley at hansenpartnership.com> wrote:

[cut]

> Better tools are always nice, but I agree they won't address the "lack
> of reviewers" problem.  I'm a little concerned that the real problem
> is that the complexity of the system makes it unapproachable except to
> the few who can afford to work in one area full-time (I'm talking
> about the complexity of accumulated warts, not the unavoidable
> complexity of the hardware itself).

I agree.

If a change is deep enough, you need to know a lot about the code that's
already there to review it, and not just about one subsystem usually, and you
also need to know *why* it is there which in many cases is undocumented and may
be specific to certain special cases.

Rafael



More information about the Ksummit-discuss mailing list