[Ksummit-discuss] [TOPIC] Encouraging more reviewers

Daniel Vetter daniel.vetter at ffwll.ch
Wed May 28 14:39:15 UTC 2014


On Wed, May 28, 2014 at 4:32 PM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> We should have a special tag for reviewers who find actual bugs because
> that is the best sort of reviewer.

My approach has been to insist on an in-patch revision log which gets
included in the commit. And that for any changes and bugs spotted the
reviewer/commenter must be acknowleged. See e.g.
d978ef14456a38034f6c0e for a very nice example of that. But that's
also a good example for no tag to acknowledge all the work that went
into this review/patch, since I've done the final review myself and
only put my sob onto the patch.

Something more standardized here would indeed be nice. There's still
the problem that some review takes a really long time (e.g. if there's
lots of design considerations), and other patches can be reviewed
quickly. So a binary tag will always be lacking.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Ksummit-discuss mailing list