[Ksummit-discuss] Reforming Acked-by (was Re: [TOPIC] Encouraging more reviewers)

[Rafael J. Wysocki]

On Friday, May 30, 2014 11:06:40 AM Steven Rostedt wrote:
> On Thu, 29 May 2014 23:03:28 +0200
> "Rafael J. Wysocki" <rjw at rjwysocki.net> wrote:
> 
> 
> > Well, perhaps we can reserve the Acked-by for maintainers and add
> > something like Supported-by for the 2nd meaning.
> 
> Or add a new tag for maintainers. I like:
> 
>  Approved-by:
> 
> As that is what the meaning of the maintainer acked-by is.  I sometimes
> use Acked-by when I'm not the maintainer of the code but the code
> changes something related to tracing, or something else I dabble in
> (interrupts, scheduler, etc). Code that I may not maintain, but
> something I do work with. Acked-by to me isn't limited to a maintainer,
> but for those that deal with the code, and agree with the change.
> Supported-by gives the meaning that I'm funding that change.

Right.

> Where as, a maintainer could pass in an "Approved-by" which means "Yes,
> I approve this change and it may go through another tree instead of
> mine".

That's what an ACK means, though, isn't it?

To me, really, Acked-by from a non-maintainer is something like a "+1" in G+.

I would prefer the new tag to suggest that meaning more directly.  Something
like "Fine-by", maybe?

Rafael