[Ksummit-discuss] [TOPIC] Encouraging more reviewers

Greg KH greg at kroah.com
Fri May 30 23:40:03 UTC 2014


On Fri, May 30, 2014 at 10:28:58AM -0700, Paul E. McKenney wrote:
> On Thu, May 29, 2014 at 10:41:22AM -0700, Greg KH wrote:
> > On Thu, May 29, 2014 at 05:28:11PM +0800, Li Zefan wrote:
> > > On 2014/5/29 5:32, Thomas Gleixner wrote:
> > > > On Wed, 28 May 2014, Mark Brown wrote:
> > > > 
> > > >> On Wed, May 28, 2014 at 05:44:41PM +0000, Luck, Tony wrote:
> > > >>
> > > >>>> There's a world of difference between thanking people for review and a
> > > >>>> detailed account of all the changes made in every single iteration of
> > > >>>> the review.
> > > >>
> > > >>> This is already covered in Documentation/SubmittingPatches. Quoting
> > > >>> lines 585-592 (see last sentence):
> > > >>
> > > >> Right, but Daniel is proposing lifting that above the --- and including
> > > >> it in git.
> > > > 
> > > > What you really want is:
> > > > 
> > > > Link: https://lkml.kernel.org/r/MESSAGE_ID_OF_PATCH
> > > > 
> > > > It's way more useful than any of the v1-n writeups, which are most of
> > > > the time just a completely waste of electrons. Even if written well,
> > > > without the actual review context they are pretty pointless.
> > > > 
> > > 
> > > A QA asked me about kernel development process. One of his question is,
> > > he found some valuable information in the discussion of the patch often
> > > won't be added to the changelog, so providing the commit how to find
> > > the discussion?
> > 
> > A research group has created a tool that takes a given git commit, finds
> > the mailing list discussion for that patch.  It was posted to lkml 6 or
> > so months ago, you should point them at that tool if they want to do
> > this.
> 
> This one?  https://lkml.org/lkml/2014/3/11/2

Yes, that's it.

greg k-h


More information about the Ksummit-discuss mailing list