[Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

[Jason Cooper]

On Tue, Jul 14, 2015 at 04:31:28PM +0100, David Woodhouse wrote:
> On Mon, 2015-07-13 at 01:00 +0300, Laurent Pinchart wrote:
> > 
> > > And then I can *read* them before sending them, which is good practice
> > > anyway. Am I the only person who often finds a final minor nit with
> > > their own patch, in that final read-through just before hitting 'send'
> > > on an email?
> > 
> > Certainly not, but what prevents you from doing that with git-send-email ? 
> 
> I don't know. It's not that I *can't* do that with git-send-email.
> 
> But I seem to see things differently when it's in a mail compose
> window, and I *do* spot trivial issues there, that I've missed when
> actually editing the code and even reviewing patches in gitk/etc.

I agree.  There's something different about viewing a patch in the mail
client vs in an editor or pager.

> Perhaps it's just the additional mental stimulus of physically
> preparing to hit the 'send' button and send it out to the world with my
> name on it.

It could also be that we're conditioned to reviewing patches in the mail
client.  So seeing the patch there triggers review-mode vice write-mode.

But I also think there's something about the review process prior to
'send' that catches mistakes as well.

thx,

Jason.