[Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

Steven Rostedt rostedt at goodmis.org
Thu Jul 16 16:52:16 UTC 2015


On Thu, 16 Jul 2015 09:24:56 -0700
Tim Bird <tim.bird at sonymobile.com> wrote:


> That's really good feedback.  I've often assumed that if you saw something
> that needed fixing, you had a responsibility to properly format a patch
> so as not to burden the maintainer.  I've labeled my own "best-effort,
> but-probably-not-mainlinable" patches as [RFC PATCH..].  Would it be
> worth having a convention for that sort of thing?

At a minimum, the patch should not be html, an attachment, nor have
broken whitespace where the patch doesn't apply. But other than that,
just report the bug and say "this fixes it for me". And if it is a real
bug, the maintainer should take it.

Now, some maintainers will want to let the author have credit for the
patch, and may ask the author to format it differently such that they
can submit the patch with the original author as credited. I'll do that
as not to make the fix just with my name on it. So, if you really just
want the fix upstream, and don't want to bother with the hassle and get
the author credit for the change, simply state that. Something like: 

---
Note, this patch fixes the bug for me. If there's a better solution, or
it needs tweaking feel free to make the change. I don't need to be
author of the patch, a Reported-by is fine with me.

The '---' is to have that not be part of the change log in case they
do take the patch as is.

If it's not much tweaking, I'll take the patch, make the modifications
I want, and just add a comment to the change log about my updates,
leaving the original author as the author of the patch.

-- Steve


More information about the Ksummit-discuss mailing list