[Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

Bjorn Helgaas bhelgaas at google.com
Wed Jul 22 13:57:34 UTC 2015


On Wed, Jul 22, 2015 at 8:04 AM, Steven Rostedt <rostedt at goodmis.org> wrote:
> On Tue, 21 Jul 2015 18:54:36 +1000
> NeilBrown <neilb at suse.com> wrote:
>
>> On Tue, 21 Jul 2015 10:00:33 +0800 Zefan Li <lizefan at huawei.com> wrote:
>>
>> > > Then it should just be case of of asking Stephen to "put this tree last
>> > > in linux-next", and Linus to "pull this one last, right before
>> > > releasing -rc1". And getting the timing right for the script to run.
>> > >
>> >
>> > This makes git-blame less useful, and that's one of the reasons some
>> > maintainers don't like trivial cleanups.
>>
>> Sounds like we need to propose an enhancement to "git-blame"...
>>
>
> No need. I use git blame all the time. Trivial patches don't bother me.
>
> $ git blame foo.c
>
> $ git show abc123
>
> Sees that it's a trivial fix
>
> $ git blame abc123~1 foo.c
>
> $ git show def890
>
> More changes I don't care about
>
> $ git blame def890~1 foo.c
>
> $ git show cde456
>
> Ah! that's the change I was looking for!

I don't know if you'd find this more work or less, but I use "git log
-p foo.c" for this instead of git blame.  Unless there's been a rename
or a move between files, one invocation is usually enough.

Bjorn


More information about the Ksummit-discuss mailing list