[Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

Paul E. McKenney paulmck at linux.vnet.ibm.com
Sun Jul 26 23:13:56 UTC 2015


On Fri, Jul 10, 2015 at 04:49:38PM -0400, Steven Rostedt wrote:
> On Thu, 9 Jul 2015 16:13:52 -0700
> josh at joshtriplett.org wrote:
> 
> 
> > That assumes the patch actually has issues.  To use the reviews I do on
> > RCU patches as an example, in a patch series, I might reply to a few
> > patches with "here are some issues; with those fixed, Reviewed-by...",
> > and then reply to the remaining unproblematic patches (individually or
> > in aggregate) with just the Reviewed-by.
> 
> Josh, I read your reviews. Yes, you have a bunch of single "Reviewed-by"
> tags, but you also have a lot of emails with substantially significant
> comments. What Ted is saying, is to see how many significant replies one
> has. In fact, I would say if we were to automate this, each significant
> reply (one with actual comments), would increase the weight that a
> single "Reviewed-by" email would carry. That way people like yourself
> would have more weight attached to emails with single "Reviewed-by"
> than others that don't have many emails with actual comments attached.

Just to state the obvious, I greatly value Josh's reviews as well,
especially the ones where he points out a bug.  Much easier than
finding them the hard way!  ;-)

							Thanx, Paul



More information about the Ksummit-discuss mailing list