[Ksummit-discuss] [TECH TOPIC] tools/Makefile: Fix Many Many problems and inconsistencies

Josh Triplett josh at joshtriplett.org
Tue Aug 2 08:27:30 UTC 2016


On Tue, Aug 02, 2016 at 09:31:05AM +0200, Arnd Bergmann wrote:
> On Monday, August 1, 2016 10:02:33 PM CEST Josh Triplett wrote:
> > On Mon, Aug 01, 2016 at 08:46:05PM -0700, Randy Dunlap wrote:
> > > and subdir Makefiles.
> > > 
> > > Examples:
> > > 
> > > Use/honor O=outputdir consistently instead of building in <kerneltree>/tools.
> > > (check/compare kernel commit bf35182ffcd00d8b36d56210ffdac110e5624d7d)
> > > 
> > > Honor MAKEFLAGS (well, they aren't even passed to tools/Makefile AFAICT.
> > > from an execution log:
> > > make LDFLAGS= MAKEFLAGS="" O=/local/lnx/kernel/lnx-47/TOOLS subdir=tools -C ../tools/ all
> > > 
> > > Use make's "findstring" correctly (see patch below)
> > > 
> > > There are lots of other problems unless I have just had too much too drink tonight,
> > > so here's the TECH TOPIC:
> > > 
> > > In a 1.5 hour code crunch session, get a bunch of interested people together to fix
> > > a lot of problems quickly.  Then I will be a guinea pig tester.  :)
> 
> I'd be interested in this too.
> 
> > Another pattern to look for: any instance of
> > ifeq ($(CONFIG_FOO),y)
> > where CONFIG_FOO is a tristate symbol should generally become
> > ifneq ($(CONFIG_FOO),n)
> 
> I tend to use
> 
> ifdef CONFIG_FOO
> 
> which seems more straightforward (fewer parentheses). Anything wrong
> with that?

No, that's fine.  And I had a typo above, as well; I meant to write:
ifneq ($(CONFIG_FOO),)


More information about the Ksummit-discuss mailing list