[Linux-kernel-mentees] [PATCH v3] staging: rtl8723bs: Fix checkpatch.pl warnings
Greg KH
gregkh at linuxfoundation.org
Sat Apr 27 06:31:18 UTC 2019
On Sat, Apr 27, 2019 at 11:20:20AM +0530, Vandana BN wrote:
> This patch resolves coding style brace warning and constant on right warning.
> WARNING: Comparisons should place the constant on the right side of the test
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Vandana BN <bnvandana at gmail.com>
I need a "real name" here, and in the From: line. Unless I am mistaken
and your last name is just "BN" and that is how you sign legal
documents? If so, please let me know.
> ------
> v2- Edited commit message and subject
> v3- Edited commit message
> ------
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 0de1e12a676e..3fb09ad45a67 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -1425,9 +1425,8 @@ int proc_get_btcoex_info(struct seq_file *m, void *v)
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> pbuf = rtw_zmalloc(bufsize);
> - if (NULL == pbuf) {
> + if (pbuf == NULL)
checkpatch.pl was ok with this? It didn't say to write this line
differently after you ran this patch through it?
thanks,
greg k-h
More information about the Linux-kernel-mentees
mailing list