[Linux-kernel-mentees] [PATCH] staging: media: bcm2048: Fixed style error ERROR: Macros with complex values should be enclosed in parentheses found using scripts/checkpatch.pl

Puranjay Mohan puranjay12 at gmail.com
Mon Apr 29 15:17:19 UTC 2019


On Mon, Apr 29, 2019 at 04:56:35PM +0200, Greg KH wrote:
> On Mon, Apr 29, 2019 at 08:20:02PM +0530, Puranjay Mohan wrote:
> > Signed-off-by: Puranjay Mohan <puranjay12 at gmail.com>
> > ---
> 
> I think your subject line needs a bit of work :)
> 
> Also, I can't take patches without any changelog text.
> 
> >  drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > index d9b02ff66259..599da6c977ed 100644
> > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > @@ -2000,7 +2000,7 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
> >  	return sprintf(buf, mask "\n", value);				\
> >  }
> >  
> > -#define DEFINE_SYSFS_PROPERTY(prop, prop_type, mask, check)		\
> > +#define (DEFINE_SYSFS_PROPERTY(prop, prop_type, mask, check))		\
> >  property_write(prop, prop_type, mask, check)				\
> >  property_read(prop, mask)						\
> 
> Wait, did you build this patch?  Are you sure it is doing what you think
> it is doing?
> 
> thanks,
> 
> greg k-h

It is my first patch ever, can you guide me on how to resend the patch
with the corrections.
After adding the parentheses around the Macro, the Error was not showing
up with the checkpatch.pl so I thought it corrected it.

thanks,


More information about the Linux-kernel-mentees mailing list