[Linux-kernel-mentees] [PATCH v2] Documentation: filesystems: convert vfat.txt to RST

OGAWA Hirofumi hirofumi at mail.parknet.co.jp
Fri Dec 20 04:53:35 UTC 2019


Jonathan Corbet <corbet at lwn.net> writes:

> On Thu, 21 Nov 2019 10:06:05 -0300
> "Daniel W. S. Almeida" <dwlsalmeida at gmail.com> wrote:
>
>> From: "Daniel W. S. Almeida" <dwlsalmeida at gmail.com>
>> 
>> Converts vfat.txt to the reStructuredText format, improving presentation
>> without changing the underlying content.
>> 
>> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida at gmail.com>
>> -----------------------------------------------------------
>> Changes in v2:
>> Refactored long lines as pointed out by Jonathan
>> Copied the maintainer
>> Updated the reference in the MAINTAINERS file for vfat
>> 
>> I did not move this into admin-guide, waiting on what the 
>> maintainer has to say about this and also about old sections
>> in the text, if any.
>
> This one, too, could user a bit less markup, and more consistent markup.
> If you have to mark up literal text, for example, it should be ``literal``,
> not *emphasis*.  But please think about whether it needs marking up at all.
>
> I have one other thing here, that could use input from the vfat maintainer:

Sorry, I have very small knowledge in Documentation stuff. So I was
thinking no need my input...

I don't know what markup is proper here. My opinion would be, let's
make it be consistent with other Documents/*.

>> +BUG REPORTS
>> +===========
>> +If you have trouble with the *VFAT* filesystem, mail bug reports to
>> +chaffee at bmrc.cs.berkeley.edu.
>> +
>> +Please specify the filename and the operation that gave you trouble.
>> +
>> +TEST SUITE
>> +==========
>> +If you plan to make any modifications to the vfat filesystem, please
>> +get the test suite that comes with the vfat distribution at
>> +
>> +`<http://web.archive.org/web/*/http://bmrc.berkeley.edu/people/chaffee/vfat.html>`_
>> +
>> +This tests quite a few parts of the vfat filesystem and additional
>> +tests for new features or untested features would be appreciated.
>
> What are the chances that the above email address works at all, especially
> given that the associated web page has to be dug out of the wayback
> machine?  We should really try to avoid perpetuating obviously wrong
> information when we can.  Hirofumi, do you have any thoughts on what might
> replace this section?

Those sections are so long years didn't work, IIRC. So IMHO, we can
remove those simply. The address for bug report would work from
MAINTAINER, lkml as usual, and even bugzilla.

Thanks.
-- 
OGAWA Hirofumi <hirofumi at mail.parknet.co.jp>


More information about the Linux-kernel-mentees mailing list