[Linux-kernel-mentees] [PATCH v2] nl80211: Fix undefined behavior in bit shift
c0d1n61at3 at gmail.com
Thu Jul 4 18:34:33 UTC 2019
On Fri, Jun 28, 2019 at 03:57:05PM +0200, Johannes Berg wrote:
> On Wed, 2019-06-26 at 21:34 -0600, Shuah Khan wrote:
> > On 6/26/19 9:25 PM, Jiunn Chang wrote:
> > > Shifting signed 32-bit value by 31 bits is undefined. Changing most
> > > significant bit to unsigned.
> > >
> > > Changes included in v2:
> > > - use subsystem specific subject lines
> > > - CC required mailing lists
> > >
> > > Signed-off-by: Jiunn Chang <c0d1n61at3 at gmail.com>
> > > ---
> > Move version change lines here. They don't belong in the commit log.
> FWIW, in many cases people (maintainers) now *do* want them in the
> commit log. Here, they're just editorial, so agree, but if real
> technical changes were made due to reviews, they can indeed be useful.
Would you like me to send v3 with the change log in the patch description?
More information about the Linux-kernel-mentees