[Linux-kernel-mentees] [PATCH v4] Media: Radio: Change devm_k*alloc to k*alloc

Shuah Khan skhan at linuxfoundation.org
Tue Jun 18 16:33:42 UTC 2019


On 6/18/19 2:14 AM, Greg KH wrote:
> On Tue, Jun 18, 2019 at 12:47:02AM -0700, Luke Nowakowski-Krijger wrote:
>> Change devm_k*alloc to k*alloc to manually allocate memory.
>>
>> Memory is freed in v4l2.release callback which now calls
>> raremono_device_release to free up the appropriate memory,
>> just like in radio-shark driver.
> 
> Trailing whitespace :(
> 
> Please fix your editor.
> 
>>
>>
>> Reported-by: syzbot+a4387f5b6b799f6becbf at syzkaller.appspotmail.com
>> Signed-off-by: Luke Nowakowski-Krijger <lnowakow at eng.ucsd.edu>
>> ---
> 
> If this is a new version, properly version your patches, with a v2 and a
> description below the --- line as to what changed.  The documentation
> should say exactly how to do this.
> 
> Also, did you submit this to syzbot for testing?  You can do that
> through the email interface.
> 
> thanks,
> 
> greg k-h

Luke,

Once you fix all the issues, please include media mailing list and
everybody get_maintainers.pl suggests and Hans Verkuil as well.

thanks,
-- Shuah




More information about the Linux-kernel-mentees mailing list