[Linux-kernel-mentees] [PATCH] staging: soc_mt9v022: replace symbolic permission with octal permission

Harshavardhan Unnibhavi hvubfoss at gmail.com
Fri Jun 21 16:44:53 UTC 2019


Resolved following checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
using octal permissions '0444'.

Signed-off-by: Harshavardhan Unnibhavi <hvubfoss at gmail.com>
---
 drivers/staging/media/soc_camera/soc_mt9v022.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/soc_camera/soc_mt9v022.c b/drivers/staging/media/soc_camera/soc_mt9v022.c
index e7e0d3d29499..f73f5460663c 100644
--- a/drivers/staging/media/soc_camera/soc_mt9v022.c
+++ b/drivers/staging/media/soc_camera/soc_mt9v022.c
@@ -25,7 +25,7 @@
  */
 
 static char *sensor_type;
-module_param(sensor_type, charp, S_IRUGO);
+module_param(sensor_type, charp, 0444);
 MODULE_PARM_DESC(sensor_type, "Sensor type: \"colour\" or \"monochrome\"");
 
 /* mt9v022 selected register addresses */
-- 
2.17.1



More information about the Linux-kernel-mentees mailing list