[Linux-kernel-mentees] [PATCH] staging: rtl8732bs: replace symbolic permission with octal permission

Greg KH gregkh at linuxfoundation.org
Sat Jun 22 06:28:15 UTC 2019


On Sat, Jun 22, 2019 at 11:03:58AM +0530, Sushma Unnibhavi wrote:
> Resolved following checkpatch issue:
> WARNING: Symbolic permissions 'S_IXUGO' are not preferred. Consider using octal permissions '0111'
> 
> Signed-off-by: Sushma Unnibhavi <sushmaunnibhavi425 at gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Is this a "v2" patch?  If so, you always have to say that as per the
kernel documentation and put what changed below the --- line.

Also, you can not send patches based on top of a previous patch, unless
that patch was accepted.  And I don't think I accepted your previous
patch, right?

thanks,

greg k-h


More information about the Linux-kernel-mentees mailing list